BCFR-1099 sei custom log index #15858
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AER Report: CI Core ran successfully ✅AER Report: Operator UI CI ran successfully ✅ |
|
DylanTinianov
approved these changes
Jan 7, 2025
| if el.Method == "eth_getLogs" { | ||
| r.rpcLog.Critical("evmclient.BatchCallContext: eth_getLogs is not supported") | ||
| return errors.New("evmclient.BatchCallContext: eth_getLogs is not supported") | ||
| } |
There was a problem hiding this comment.
Does this mean we can't support LogPoller / CCIP on AStar?
There was a problem hiding this comment.
Oh, nevermind... I forgot we only use batch requests with eth_getBlockByNumber. Still, very strange that AStar wouldn't support this! We have thought about changing the eth_getLogs requests to a batched request, I guess if we do that we'll have to fall back to the older method on AStar 🤔
reductionista
approved these changes
Jan 7, 2025
stackman27
pushed a commit
to smartcontractkit/ccip
that referenced
this pull request
Jan 8, 2025
Patch with minor adjustments from the chainlink repo [PR](smartcontractkit/chainlink#15858). Adjustments were caused by differences between repos. It's easier to do&review them than to apply all the changes made to chainlink repo that included MultiNode abstraction with 5k lines changed.
ogtownsend
pushed a commit
to smartcontractkit/ccip
that referenced
this pull request
Jan 8, 2025
Patch with minor adjustments from the chainlink repo [PR](smartcontractkit/chainlink#15858). Adjustments were caused by differences between repos. It's easier to do&review them than to apply all the changes made to chainlink repo that included MultiNode abstraction with 5k lines changed.
ogtownsend
added a commit
to smartcontractkit/ccip
that referenced
this pull request
Jan 8, 2025
Cherry picking core PRs into ccip: 1. smartcontractkit/chainlink#15828 2. smartcontractkit/chainlink#15858 3. smartcontractkit/chainlink#15735 --------- Co-authored-by: Jasmin Bakalovic <[email protected]> Co-authored-by: joaoluisam <[email protected]> Co-authored-by: Friedemann Fürst <[email protected]> Co-authored-by: Sishir Giri <[email protected]> Co-authored-by: Dmytro Haidashenko <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added custom calculation of log's index to match LogPoller's expectations